-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
MDEV-37197 - Install PAM modules and systemd units from /lib to /usr/lib #4065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Job buildbot/amd64-debian-11-debug-ps-embedded failed on test unrelated to changes in this PR: |
|
Job buildbot/amd64-ubuntu-2004-debug failed on test unrelated to changes in this PR: |
grooverdan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
After validating SLES/OpenSUSE and RHEL this can continue on the RPM side (noting the Fedora change https://fedoraproject.org/wiki/Changes/Unify_bin_and_sbin).
This has almost certainly missed the 11.8 stable GA release.
Given the symlinking that has been in place for a long time and services that reference these non-user files don't do so by full path maybe there isn't a concern in changing the install location?
|
OpenSUSE implemented the I don't have access to a SUSE system to check, but pretty sure if has it already. Fedora did the change in 2012 and presumably RHEL 7 in 2014 had it (10+ years ago). |
|
ack. Interesting not visible in the BCI which I thought was SLES based: |
|
Rebased and changed target to 'main' as this by now surely missed the 11.8 window. |
|
CI job buildbot/amd64-debian-12 failed test that is unrelated to this change: CI job continuous-integration/appveyor/pr also failed on unrelated issue: |
|
CI job amd64-ubuntu-2204-debug-ps triggered by Daniel Black failed on unrelated issue: |
|
Otto, thanks for the PR. Always good to get through migrations. You mentioned the Debian /usr merge started a while back. If you want to take to to 11.8 or 11.4 that's ok by me if those correspond to the Debian 11/12 (?) version that MariaDB has where the merge/move occurred. There's sufficient tests around PAM and systemd checks in CI to catch if anything is amiss. As its probably release note worthy the MDEV-37197 has been created for this task. Can you reword the commit message a bit, you're doing Debian/Ubuntu only changes but reading the commit message it reads looks like you're doing it for everyone. The RPM changes become very dependant on distro which needs more investigation to be done relliably. |
|
This is modifying |
|
Note to self: After rebase on July 10th, CI fully green ✔️ |
sure, ok. Commit message should reflect this. |
|
Rebased on latest 'main' now. CI job buildbot/amd64-msan-clang-20 failed on: CI job continuous-integration/appveyor/pr failed on: Neither are due to my change - both are due to the current 'main' branch already being broken and/or CI having unstable tests. |
018ed9f to
d09b47b
Compare
|
Rebased on latest 'main' now. CI job continuous-integration/appveyor/pr failed on: This is not a regression from this PR, but due to the current 'main' branch already being broken and/or CI having unstable tests. |
|
#4065 (comment) is still unaddressed. Commit message is general but implementation is Debian specific. Can you put the MDEV in the commit message too please. |
082a54c to
76d4427
Compare
|
Ack, commit prefixed with |
|
Rebased on latest 'main' now. CI job continuous-integration/appveyor/pr failed on: CI job buildbot/amd64-ubuntu-2204-debug-ps failed on: Neither are due to my change - both are due to the current 'main' branch already being broken and/or CI having unstable tests. |
76d4427 to
2d38afe
Compare
|
Rebased on latest 'main'. Can somebody please approve this? I don't see any objections or reasons not to merge. |
2d38afe to
238f9f3
Compare
|
Now CI job Build on Windows ARM64 / build (pull_request) failed on: And CI job buildbot/amd64-ubuntu-2204-debug failed on: Both failures unrelated to this PR contents. |
238f9f3 to
acd094b
Compare
|
Rebased on latest 'main'. Please merge already, this is a simple change. 🙏 |
|
All CI failures are unrelated to the changes in this PR. buildbot/amd64-ubuntu-2204-debug continuous-integration/appveyor/pr |
|
Lets leave the test failures that are unrelated as JIRA entries that are part of https://jira.mariadb.org/browse/MDEV-36647. |
…t /lib) Since Fedora 17 and about 2012, the directory /lib has been a symlink to /usr/lib. Debian started a similar migration in 2019. Nowadays all major Linux distributions have a merged /usr, and the canonical location for files should be /usr/lib instead of just /lib. The location of PAM modules and systemd files is the last remaining `*_DEB` variables should fully complete the usr merge migration. Additionally re-applied `debputy reformat --style=black` to get files sorted in a standardized order. References: - https://fedoraproject.org/wiki/Features/UsrMove - https://www.debian.org/releases/bookworm/amd64/release-notes/ch-information.en.html#a-merged-usr-is-now-required - https://www.freedesktop.org/wiki/Software/systemd/TheCaseForTheUsrMerge/
|
Rebased on latest 'main' to ensure this PR does not have any extra merge commits. |
Description
Since Fedora 17 and about 2012, the directory /lib has been a symlink to /usr/lib. Debian started a similar migration in 2019. Nowadays all major Linux distributions have a merged /usr, and the canonical location for files should be /usr/lib instead of just /lib.
The location of PAM modules and systemd files is the last remaining part in MariaDB to fully complete the usr merge migration. Stable releases should not move files around, so target MariaDB 11.8 as the first release to have the /usr merge fully completed.
References:
Release Notes
How can this PR be tested?
CI should continue to be green for builds, installs and upgrades.
Basing the PR against the correct MariaDB version
PR quality check